Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert#[non_exhaustive] on borsh::schema::Definition #200

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Aug 18, 2023

it's part of #194 resolution.

allows not to have a serde derivation expanded and patched in near-abi-rs#23

@dj8yfo dj8yfo changed the title chore: remove #[non_exhaustive] on borsh::schema::Definition chore: revert#[non_exhaustive] on borsh::schema::Definition Aug 18, 2023
@dj8yfo dj8yfo marked this pull request as ready for review August 18, 2023 12:06
@dj8yfo dj8yfo requested a review from frol as a code owner August 18, 2023 12:06
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this means that adding more enum variants to Definition will be a breaking change, but I don't think we will need it, and in the worst case we can keep this type and create a new extended type and expose it with another getter method.

@dj8yfo dj8yfo merged commit 70c0541 into master Aug 24, 2023
@dj8yfo dj8yfo deleted the remove_definition_non_exaustive branch August 24, 2023 18:41
@frol frol mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants