chore!: PartialOrd
-> Ord
bound for hashcollections
#203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is part of #51 resolution.
It addresses the following comments of review:
Second comment is addressed by second commit: feat!: raise bound on keys in hashcollections PartialOrd -> Ord.
Code with
f32
andf64
won't be affected by this breaking change, asf32
andf64
aren'tEq
, so it's not possible to constructHashSet
orHashMap
with these types as keys in the first place (insert
in both collections requireEq
bound).