chore!: make BorshSchema::{add_definition,schema_container} free-standing funcs
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
changed the title
BorshSchema::add_definition default implementation a f…BorshSchema::add_definition a free-standing func
dj8yfo
changed the title
BorshSchema::add_definition a free-standing funcBorshSchema::{add_definition,schema_container} free-standing funcs
dj8yfo
force-pushed
the
schema_changes_matklad_review
branch
from
5697dd2 to
3f90bec
Compare
dj8yfo
force-pushed
the
schema_changes_matklad_review
branch
from
3f90bec to
5183e29
Compare
frol
approved these changes
Aug 28, 2023
…ree-standing func
dj8yfo
force-pushed
the
schema_changes_matklad_review
branch
from
5183e29 to
b5a5b63
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #51 resolution
This pr addresses the following comments of review: