-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: impl details of #[callback_unwrap]
#1321
Conversation
about `callback_unwrap`/`callback_result` attributes order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 8
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for finalizationThe pull request is merged, you have 24 hours to finalize your scoring. The scoring ends Fri Mar 7 07:44:04 2025
Your contribution is much appreciated with a final score of 8! @akorchyn received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
/// - [examples/adder](https://github.com/near/near-sdk-rs/blob/9596835369467cac6198e8de9a4b72a38deee4a5/examples/adder/src/lib.rs?plain=1#L30) | ||
/// - [examples/adder](https://github.com/near/near-sdk-rs/blob/9596835369467cac6198e8de9a4b72a38deee4a5/examples/adder/src/lib.rs?plain=1#L31) | ||
/// - [examples/callback-results](https://github.com/near/near-sdk-rs/blob/9596835369467cac6198e8de9a4b72a38deee4a5/examples/callback-results/src/lib.rs?plain=1#L51) | ||
/// - [examples/callback-results](https://github.com/near/near-sdk-rs/tree/master/examples/callback-results/src/lib.rs?plain=1#L51) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: this link has to be changed to blob/commit
and line ?plain=1#Lxx
adjusted to what the link was an example for
The following can be changed to blob/commit
links too in a similar fashion (and lines ?plain=1#Lxx
adjusted to lines containing api to what the links were examples of):
├──near-sdk
│ └──src
│ └──environment
│ └──env.rs
│ ├──764: /// Example usages of this low-level api are <https://github.com/near/near-sdk-rs/tree/master/examples/factory-contract/low-level/src/lib.rs> and <https://github.com/near/near-sdk-rs/blob/master/examples/cross-contract-calls/low-level/src/lib.rs>
│ ├──820: /// Example usages of this low-level api are <https://github.com/near/near-sdk-rs/tree/master/examples/factory-contract/low-level/src/lib.rs> and <https://github.com/near/near-sdk-rs/blob/master/examples/cross-contract-calls/low-level/src/lib.rs>
│ └──1477: /// Example usages: [one](https://github.com/near/near-sdk-rs/tree/master/examples/cross-contract-calls/low-level/src/lib.rs), [two](https://github.com/near/near-sdk-rs/tree/master/examples/factory-contract/low-level/src/lib.rs)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
- Coverage 80.18% 80.16% -0.03%
==========================================
Files 104 104
Lines 14829 14831 +2
==========================================
- Hits 11891 11889 -2
- Misses 2938 2942 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
#[callback_unwrap]
#1312near-sdk
#1265only improved wording/fmt, where it was off for checked items
near-sdk
#1265this is a re-open of #1319 , which failed due to some mysterious reason in https://github.com/near/near-sdk-rs/actions/runs/13638771921/job/38125370846 on windows. there's a suspicion that was a one-off fluke of Swatinem/rust-cache@v1, but no hard proof for that.