Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collections): unstable new vector implementation #402
feat(collections): unstable new vector implementation #402
Changes from 44 commits
1e90139
1446ad0
babd92e
c2e39b8
6efbc64
13e0662
63de2af
b884f32
e5e1ca8
b35a49b
4f360b8
38cc873
486cd46
5aed715
c0d088d
8fb7324
e56b207
a6ba75b
75ffd20
1335407
b378bf4
7a7de54
e67dc3f
c51b1ce
fffc91f
39648fa
82eb8fa
2f602b9
7dc6049
9e54bb6
f9b94f8
e531d1c
f6bc152
4b0da03
032a968
a3d344f
c0cb627
29b0fdf
6b89716
b8380c3
78875b8
2b5f8f5
00acbb6
482ab02
9e0f9ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the
Debug
here? Genuinely don't know but saw this innear-sdk/src/collections/vector.rs
and thought I'd mentioned it, seeing if this is a good pattern to follow:#[cfg_attr(not(feature = "expensive-debug"), derive(Debug))]
near-sdk-rs/near-sdk/src/collections/vector.rs
Line 22 in 072b477
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, since derived, it would use this pattern for when the feature is enabled. There is nothing in the iterator that would be different here