fix(standards): redundancy and inaccuracy in nft storage measure #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
reviewed
Jun 17, 2022
| @@ -53,7 +51,7 @@ pub struct NonFungibleToken { | |||
|
|
|||
| #[derive(BorshStorageKey, BorshSerialize)] | |||
| pub enum StorageKey { | |||
| TokensPerOwner { account_hash: Vec<u8> }, | |||
| TokensPerOwner { account_id_hash: CryptoHash }, | |||
There was a problem hiding this comment.
Still am advocating for this to be an AccountId. You charge for a full length account id, but it will reduce storage on average since most real users have shorter account ids, and it will not require a host call to produce a hash.
There was a problem hiding this comment.
Furthermore a state dump will make it clear who the owner is.
There was a problem hiding this comment.
This would be a state-breaking change, though. This can come if there are breaking changes or if the standards were re-written.
Also, this makes it harder to find things based on a prefix because of the variable-length prefix, so not a clear win anyway.
|
oops, didn't see #843 will just use/build off that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #844
@BenKurrek would love your input on this