Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement linters.one-resource-per-ns #112

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Implement linters.one-resource-per-ns #112

merged 3 commits into from
Jan 28, 2020

Conversation

vemv
Copy link
Contributor

@vemv vemv commented Jan 28, 2020 •
edited
Loading

Brief

Fixes #78 (at least partially; I extracted an extended use case to #113)

QA plan

  • Tests added
  • Try the alpha project-wide somewhere
    • Done (shared privately)

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

@vemv vemv mentioned this pull request Jan 28, 2020
Open
@vemv vemv marked this pull request as ready for review January 28, 2020 08:18
@vemv vemv requested a review from thumbnail January 28, 2020 08:18
thumbnail
thumbnail approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@thumbnail thumbnail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Impressive to see the impact on key 👍

test/integration/formatting_stack/linters/one_resource_per_ns.clj
Comment on lines +15 to +17
(is (= (sut/analyze "test/integration/formatting_stack/linters/one_resource_per_ns.clj")
())))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about (is (empty? (sut/analyze ...))) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno. Asserting values is more specific than asserting computations (not good to author tests that pass on many inputs - seems sloppy); and also seeing the actual output of given function seems pretty useful.

@vemv vemv force-pushed the 78--one-resource-per-ns branch from 3c45222 to 6f1f783 Compare January 28, 2020 09:29
@vemv vemv merged commit dc0a8e4 into master Jan 28, 2020
@vemv vemv deleted the 78--one-resource-per-ns branch January 28, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thumbnail thumbnail thumbnail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linter: one resource per ns
2 participants
@vemv @thumbnail