-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce :overrides
option
#147
Conversation
@thumbnail : Progressed quite a bit. Although the branch isn't pretty, the extended specs, examples, protocols, tests etc should make it quite clear the overall intended API. You might want to take over the branch, as I see it it's 90% there. |
reporter | ||
in-background?]}] | ||
(speced/defn format! [& {:keys [^vector? strategies | ||
;; XXX rename `formatters` to `formatter-factories` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Important to address this XXX)
Closing so that I'll push a rebased version. |
Brief
Implements #134 (comment)
Starting from this PR,
:overrides
becomes the primary API for customizing things: as a consumer, one should:git-status-formatter
,branch-formatter
,project-formatter
...and should not:
core/format!
directlyTODO
git-status-formatter
,branch-formatter
,project-formatter
all deserve some test coverage.git-status-formatter
,branch-formatter
,project-formatter
impl
sub-nses forgit-status-formatter
,branch-formatter
,project-formatter
format-and-lint!
/lint!
speced/defn default-formatters
are certainly not publicQA plan
git-status-formatter
,branch-formatter
,project-formatter
all keep workingAuthor checklist
Reviewer checklist