bump deps #73
Merged
bump deps #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now encountering an overflow error in the quickcheck properties:
```
<...>
thread 'test::parse_pretty::roundtrip::parse_pretty_roundtrip' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: PosOverflow }', rep_lang_concrete_syntax/src/parse.rs:26:45
thread 'test::parse_pretty::roundtrip::parse_pretty_roundtrip' panicked at '[quickcheck] TEST FAILED (runtime error). Arguments: (WrappedExpr(Lit(LInt(-9223372036854775808))))
Error: "called `Result::unwrap()` on an `Err` value: ParseIntError { kind: PosOverflow }"', /home/mhueschen/.cargo/registry/src/github.ghproxy.top-1ecc6299db9ec823/quickcheck-1.0.3/src/tester.rs:165:28
```
it seems like `-(2 ^ 63)` is unable to be parsed into an i64 via
`string.parse::<i64>()`. which seems weird, because it should fit...
as discovered by the quickcheck properties - most excellent! I was parsing negative numbers by registering the `-` token, then parsing the following numeric characters as a postive i64. then, if there was a `-` token, I would negate that postive number to make it negative. unfortunately this doesn't work for `minBound` of a 2s complement representation... i64 ranges from `-(2^63)` to `2^63 - 1`. `2^63` is not representable, so we were getting the overflow error.
6 tasks
mhuesch
added a commit
that referenced
this pull request
Jun 21, 2022
rustyline changed since we updated deps in #73, so wasm builds broke. this should restore them.
mhuesch
added a commit
that referenced
this pull request
Jun 21, 2022
work around lack of proper wasm support in rustyline. rustyline changed since we updated deps in #73, so wasm builds broke. solution: - depend on kkawakam/rustyline#620 PR code - fork PR branch s.t. it can't disappear on us
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've racked up a bunch of dependabot alerts b/c of using old versions of deps.
updating them helped my find a bug in the parser, so that's cool.