Update SchemaFrame styling #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed some typos - renamed default export to Docs as it's never imported as Guides
oskarhane
reviewed
Dec 6, 2019
| @@ -24,7 +24,7 @@ import Directives from 'browser-components/Directives' | |||
| import Carousel from '../Carousel/Carousel' | |||
| import Slide from '../Carousel/Slide' | |||
|
|
|||
| export default class Guides extends Component { | |||
| export default class Docs extends Component { | |||
| @@ -45,7 +45,7 @@ const HelpFrame = ({ frame }) => { | |||
| const { title, subtitle } = chapter | |||
| let { content } = chapter | |||
|
|
|||
| // The commands topic is a special case that uses dymaic data | |||
| // The commands topic is a special case that uses dynamic data | |||
| <br /> | ||
| <p className='lead'>Execute the following query for more information</p> | ||
| <figure> | ||
| <pre className='code runnable'>CALL db.schema.visualization</pre> |
There was a problem hiding this comment.
neo4j-browser needs (at the time of writing this) to support Neo4j 3.4+, and db.schema.visualization does not exist in Neo4j 3.4. There it's named db.schema(), so you need to do a version check here.
| @@ -47,7 +47,7 @@ export const CLUSTER_CYPHER_REQUEST = NAME + '/CLUSTER_REQUEST' | |||
| export const FORCE_CHANGE_PASSWORD = NAME + '/FORCE_CHANGE_PASSWORD' | |||
|
|
|||
| // Helpers | |||
| const queryAndResovle = async (driver, action, host, useDb = {}) => { | |||
| const queryAndResolve = async (driver, action, host, useDb = {}) => { | |||
| <SchemaTable name='Indexes' content={indexes} /> | ||
| <SchemaTable name='Constraints' content={constraints} /> | ||
| <br /> | ||
| <p className='lead'>Execute the following query for more information</p> |
There was a problem hiding this comment.
The links doesn't really show more information about the indexes and constraints, but rather semi-related info.
I would probably rewrite this to be something in the lines of: Execute the following command to visualize what's related, and how (we use that phrase in the sidebar "Saved scripts" -> "Data profiling").
nglgzz
commented
Dec 6, 2019
| @@ -32,7 +35,7 @@ import { | |||
| StyledBodyTr, | |||
| StyledTd | |||
| } from 'browser-components/DataTables' | |||
| import { Directives } from 'browser-components/Directives' | |||
| import Directives from 'browser-components/Directives' | |||
There was a problem hiding this comment.
Not sure why, but after I connected SchemaFrame to redux, the onItemClick function from Directives wouldn't work unless I imported the connected version.
oskarhane
approved these changes
Dec 6, 2019
Comment on lines
+104
to
+119
| test('SchemaFrame renders correct suggestion for Neo4j > 3.4', () => { | ||
| const indexResult = { records: [] } | ||
| const { getByText } = renderWithRedux( | ||
| <SchemaFrame indexes={indexResult} neo4jVersion={'3.5.1'} /> | ||
| ) | ||
|
|
||
| expect(getByText('CALL db.schema.visualization')).not.toBeNull() | ||
| }) | ||
|
|
||
| test('SchemaFrame renders correct suggestion for Neo4j <= 3.4', () => { | ||
| const indexResult = { records: [] } | ||
| const { getByText } = renderWithRedux( | ||
| <SchemaFrame indexes={indexResult} neo4jVersion={'3.4.1'} /> | ||
| ) | ||
|
|
||
| expect(getByText('CALL db.schema()')).not.toBeNull() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Also:
browser/modules/Docs/Docs.jsxto Docs as it's never imported as Guides