Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate docs URLs based on server version #1019

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Generate docs URLs based on server version #1019

merged 2 commits into from
Dec 13, 2019

Conversation

nglgzz
Copy link
Member

@nglgzz nglgzz commented Dec 11, 2019 •
edited by oskarhane
Loading

  • Remove :help frame for deprecated START clause
  • Show :help frame for SCHEMA command
  • Make formatting consistent for reference links on :help frames

changelog: Fix versioned links to external docs

@nglgzz nglgzz requested a review from oskarhane December 11, 2019 09:24
oskarhane
oskarhane approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks or looking through all these. Looks good to me.

src/browser/components/ManualLink.test.js
]
]

test.each(tests)('Render correct url for props %o', (props, expected) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the test.each 👍

@nglgzz nglgzz merged commit 79bc322 into neo4j:master Dec 13, 2019
@nglgzz nglgzz deleted the docs-urls branch December 13, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarhane oskarhane oskarhane approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nglgzz @oskarhane