Add initalSwitchConnectionFailEpic to rootEpic #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
approved these changes
Apr 17, 2020
| @@ -61,4 +61,26 @@ describe('Neo4j Desktop environment', () => { | |||
| .first() | |||
| .should('contain', 'Connection updated') | |||
| }) | |||
|
|
|||
| it('displays disconnected banner and connection failed frame when initial state is INACTIVE', () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the autorun play commands PR I added the initialSwitchConnectionFailEpic epic, but forgot to combine it in the root epic so it was never active. This created the bug that the server switch fail frame was not displayed when starting browser from neo4j desktop without a started database. This PR adds the epic to rootEpic to fix this bug and adds an E2E test to verify that the server switch fail frame is displayed as intended.
changelog: Fix initial load behavior when opened in Neo4j Desktop without an active db.