Allow zoom buttons on small frames (with settings config) #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR and for signing the CLA! I agree we should show the zoom controls more often and I don't even think we'd need to hide it behind a setting. It'd be reasonable to always show them. Could you keep only the icon size change and remove the setting and the |
|
@ivnnv Also, I added you to the allow-list so the CI should run your tests properly now. |
|
@OskarDamkjaer friendly ping, I reworked the PR to remove the config setting and now all tests have passed and everything seems ready. Excited to have my first contribution merged! |
|
@ivnnv Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that by historical reasons (#447) it is intentional to hide the zoom button on non-fullscreen frames., but I think nowadays we have big enough screen to have them visible (in the case the user wants, hence adding a settings option defaulting to false, just as the current behaviour).
So this PR is adding a config checkbox option to have the zoom buttons available and adapts those buttons to make them smaller accordingly.
PS: CLA sign sent