Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus reusable editor on edit #1437

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Focus reusable editor on edit #1437

merged 1 commit into from
Jun 16, 2021

Conversation

OskarDamkjaer
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer requested a review from jharris4 June 16, 2021 09:18
jharris4
jharris4 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@jharris4 jharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really well. I noticed that the connect frame doesn't auto-focus anymore, but that seems to be a regression from an earlier version, so we can fix that separately.

@OskarDamkjaer OskarDamkjaer merged commit cb55ab5 into neo4j:master Jun 16, 2021
@jharris4 jharris4 changed the title Focus reusable editor on mounting it Focus reusable editor on edit Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharris4 jharris4 jharris4 approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarDamkjaer @jharris4