Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark theme #581

Merged
merged 3 commits into from
Jun 6, 2017
Merged

Add dark theme #581

merged 3 commits into from
Jun 6, 2017

Conversation

oskarhane
Copy link
Member

Should be on par with what we had.

Some screenshots:

oskar4j 2017-06-05 at 16 29 42
oskar4j 2017-06-05 at 16 29 46
oskar4j 2017-06-05 at 16 30 10
oskar4j 2017-06-05 at 16 30 15
oskar4j 2017-06-05 at 16 30 22
oskar4j 2017-06-05 at 16 30 27
oskar4j 2017-06-05 at 16 33 25
oskar4j 2017-06-05 at 16 34 14
oskar4j 2017-06-05 at 16 40 05

@pe4cey pe4cey self-requested a review June 6, 2017 10:21
@pe4cey
Copy link
Contributor

pe4cey commented Jun 6, 2017 •
edited
Loading

The copy on the buttons during the connect/change password flow is difficult to read, as well as the
header and copy on the left hand side. See bellow:
screen shot 2017-06-06 at 11 28 39

Old codebase for comparison:
screen shot 2017-06-06 at 11 45 31

@oskarhane
Copy link
Member Author

oskarhane commented Jun 6, 2017 •
edited
Loading

Fixed now @pe4cey (made them what they should be, rather what they are in old codebase)

oskar4j 2017-06-06 at 13 19 49

@oskarhane
Copy link
Member Author

Updated again @pe4cey

pe4cey
pe4cey approved these changes Jun 6, 2017
View reviewed changes
Copy link
Contributor

@pe4cey pe4cey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pe4cey pe4cey merged commit cb6d07b into neo4j:3.0 Jun 6, 2017
@oskarhane oskarhane deleted the 3.0-dark-theme branch June 6, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pe4cey pe4cey pe4cey approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskarhane @pe4cey