Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix png download #611

Merged
merged 2 commits into from
Aug 7, 2017
Merged

Fix png download #611

merged 2 commits into from
Aug 7, 2017

Conversation

pe4cey
Copy link
Contributor

@pe4cey pe4cey commented Jul 3, 2017

Changes to Cypher results frame:

  • Only show download png in titlebar when in visualization view

  • Hide download csv in titlebar when in visualization view

changelog: Fix cypher result exports

- Better than calling `this.forceUpdate()`
@oskarhane
Copy link
Member

I'm getting js errors when trying to export PNG from viz view with changes in this PR.

From the other views I get an empty (as in 0 bytes) png file downloaded.

oskarhane-mbpt 2017-08-01 at 12 36 27

@pe4cey
Copy link
Contributor Author

pe4cey commented Aug 2, 2017

It seems to be working ok for me (tested on chrome and ff)

@pe4cey pe4cey changed the title Update state flag when vis element is assigned Fix png download Aug 3, 2017
- Hide csv download when in visualization view
@pe4cey pe4cey force-pushed the 3.0-vis-element-png branch from 79e6587 to fa35e87 Compare August 3, 2017 09:47
@pe4cey
Copy link
Contributor Author

pe4cey commented Aug 4, 2017

Branch updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants