Add ability to download a query plan as png #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
reviewed
Aug 10, 2017
| @@ -49,6 +49,8 @@ export class PlanView extends Component { | |||
| this.ensureToggleExpand(props) | |||
| } | |||
| shouldComponentUpdate (props, state) { | |||
| this.props.assignVisElement && this.props.assignVisElement(this.el, this.plan) | |||
There was a problem hiding this comment.
I don't think this is the lifecycle method to use for this. componentWillUpdate or componentWillReceiveProps would be more appropriate imo.
|
Updated |
|
If you generate multiple frames with plans in them, export as PNG will download the latest plan, even from older frames. |
oskarhane
force-pushed
the
3.0-download-plan-png
branch
from
6373895 to
da3954e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cypher result frame for
EXPLAN||PROFILEquery we display theplanview that has an interactive query plan element.This PR adds a button in the titlebar to download the query plan as a png file.