Enable cheap updated checks for cypher frame #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `.updated` to the request object and update that every time it’s updated with new data. This saves us multiple expensive `deepEquals` checks.
oskarhane
force-pushed
the
cypher-frame-spike
branch
from
6859ac0 to
f0f4946
Compare
oskarhane
force-pushed
the
cypher-frame-spike
branch
from
12889e9 to
2a80dc6
Compare
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Enable cheap updated checks for cypher frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
updatedproperty to the request object and set that every time it’s updated with new data.This avoids potential expensive
deepEqualschecks on everyshouldComponentUpdatecheck.Seems to speed up rendering of heavy queries by about 20%.
changelog: Improve Cypher result rendering performance