Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/help keys dark mode #891

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

linuslundahl
Copy link
Contributor

@linuslundahl linuslundahl commented Jan 3, 2019

  • Fixes help keys in dark mode.
  • Adjusts help keys layout.
  • Fixes Open Sans not loading correctly.

changelog: Fix :help keys in dark mode
fixes: #889

* Also adjusts the layout a bit.
 * Also adjust file permissions.
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Was the chmod changes a mistake or intentional?

Before / after screenshots would be nice, but not super important.

@@ -2,63 +2,63 @@
font-family: 'Open Sans';
font-style: normal;
font-weight: 300;
src: local('Open Sans'), local('OpenSans'), url('fonts/OpenSans-Light.ttf') format('truetype');
src: local('Open Sans Light'), local('OpenSansLight'), url('fonts/OpenSans-Light.ttf') format('truetype');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@linuslundahl
Copy link
Contributor Author

linuslundahl commented Jan 3, 2019

@oskarhane

The Open Sans files had different permissions. Gave them the same permissions as the rest of the fonts to see if that was a factor for Open Sans not loading correctly. Then just left all files with the same permission for consistency.

Before:
before

After:
after

@oskarhane oskarhane merged commit f0937af into neo4j:master Jan 3, 2019
myzero1 pushed a commit to myzero1/neo4j-browser that referenced this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:help keys unreadable with Dark Theme
2 participants