Add URL param support for populating editor with Cypher and parameters #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this be included in some |
oskarhane
force-pushed
the
cypher-url-param
branch
2 times, most recently
from
a852ab0 to
64fbe33
Compare
oskarhane
changed the title
oskarhane
changed the title
huboneo
reviewed
Aug 14, 2019
| cypher: (_, args) => args.join('\n') | ||
| cypher: (_, args) => args.join('\n'), | ||
| param: (cmdchar, args) => `${cmdchar}param ${args.join(' ')}`, | ||
| params: (cmdchar, args) => `${cmdchar}params ${args.join(' ')}` |
There was a problem hiding this comment.
do we need to worry about interoperability here? can :play accept params? Also what happens if provided params are malformed/invalid?
|
WDYT about using |
oskarhane
force-pushed
the
cypher-url-param
branch
from
c7cedd5 to
8930e10
Compare
Add newline for each query. Semi-colons are up to the user to add.
oskarhane
force-pushed
the
cypher-url-param
branch
from
8930e10 to
8088824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add newline for each query.
Semi-colons are up to the user to add.
Example usages:
http://localhost:7474/?cmd=edit&arg=RETURN%201;&arg=RETURN%20rand();http://localhost:7474/?cmd=param&arg=x%20%3d%3E%201;http://localhost:7474/?cmd=params&arg={x:1.0,%20y:%22hello%22}Since it's not limited to Cypher, but works for populating the editor with anything the command is was decided to be
edit.Cypher:
Param:
Params:
