fix(completion): use notification for on_complete & on_enter

doc/coc-api.txt

@@ -11,8 +11,8 @@ Debug extensions 				|coc-api-debug|
 
 ==============================================================================
 
-This is the guide for extend coc.nvim by create vim completion sources and
-coc.nvim extensions.
+The guide for extend coc.nvim by create vim completion sources and coc.nvim
+extensions.
 
 ------------------------------------------------------------------------------
 VIM SOURCES 					*coc-api-vim-source*
@@ -134,8 +134,8 @@ Complete function: ~
     items, word is used when not exists.
   • filterText: A string that should be used when filtering a set of
     complete items, word is used when not exists.
-  • insertText: The text to insert, could be snippet text, word is used when
-    not exists.
+  • insertText: The text to insert, could be textmate snippet text, word is
+    used when not exists.
   • isSnippet: The text to insert is snippet when is truthy value, when
     truthy and `on_complete` not provided by vim source, the `insertText` is
     expanded as textmate snippet when confirm completion.
@@ -386,7 +386,8 @@ The error messages are not stored by vim's message history, use
 
 When error happens on the vim side, the promise would be rejected when sending
 request to vim, for notifications, vim would send `nvim_error_event` to the
-NodeJS process, and the node-client would create error log for it.
+NodeJS process, and the node-client would create error log for it (could be
+opened by |:CocOpenLog|).
 
 Use the log file: ~
 

src/__tests__/handler/codelens.test.ts

@@ -225,14 +225,12 @@ describe('codeLenes featrue', () => {
     await nvim.call('setline', [1, arr])
     await doc.synchronize()
     await codeLens.checkProvider()
-    await nvim.command('normal! gg')
-    await nvim.command('normal! G')
-    await helper.wait(100)
-    let buf = codeLens.buffers.getItem(doc.bufnr)
-    let codelens = buf.currentCodeLens
-    expect(codelens).toBeDefined()
-    expect(codelens[0].command).toBeDefined()
-    expect(codelens[1].command).toBeDefined()
+    await nvim.command('normal! ggG')
+    let bufnr = doc.bufnr
+    await helper.waitValue(() => {
+      let buf = codeLens.buffers.getItem(bufnr)
+      return buf && buf.currentCodeLens && buf.currentCodeLens[0].command != null
+    }, true)
   })
 
   it('should use picker for multiple codeLenses', async () => {

src/__tests__/snippets/session.test.ts

@@ -361,8 +361,9 @@ describe('SnippetSession', () => {
       await session.start('${1:foo} bar$0', defaultRange)
       await nvim.input('<backspace>')
       await session.forceSynchronize()
-      let col = await nvim.call('col', ['.'])
-      expect(col).toBe(5)
+      await helper.waitValue(async () => {
+        return await nvim.call('col', ['.'])
+      }, 5)
     })
 
     it('should prefer range contains current cursor', async () => {

src/completion/source-vim.ts

@@ -24,10 +24,11 @@ export function checkInclude(name: string, fns: ReadonlyArray<string>): boolean
 
 export default class VimSource extends Source {
 
-  private async callOptionalFunc(fname: string, args: any[]): Promise<any> {
+  private async callOptionalFunc(fname: string, args: any[], isNotify = false): Promise<any> {
     let exists = checkInclude(fname, this.remoteFns)
     if (!exists) return null
     let name = `coc#source#${this.name}#${getMethodName(fname, this.remoteFns)}`
+    if (isNotify) return this.nvim.call(name, args, true)
     return await this.nvim.call(name, args)
   }
 
@@ -55,23 +56,22 @@ export default class VimSource extends Source {
 
   public async onCompleteDone(item: ExtendedCompleteItem, opt: CompleteOption): Promise<void> {
     if (checkInclude('on_complete', this.remoteFns)) {
-      await this.callOptionalFunc('on_complete', [item])
+      await this.callOptionalFunc('on_complete', [item], true)
     } else if (item.isSnippet && item.insertText) {
       await this.insertSnippet(item.insertText, opt)
     }
   }
 
   public onEnter(bufnr: number): void {
-    if (!checkInclude('on_enter', this.remoteFns)) return
     let doc = workspace.getDocument(bufnr)
-    if (!doc) return
+    if (!doc || !checkInclude('on_enter', this.remoteFns)) return
     let { filetypes } = this
     if (filetypes && !filetypes.includes(doc.filetype)) return
     void this.callOptionalFunc('on_enter', [{
       bufnr,
       uri: doc.uri,
       languageId: doc.filetype
-    }])
+    }], true)
   }
 
   public async doComplete(opt: CompleteOption, token: CancellationToken): Promise<CompleteResult<ExtendedCompleteItem> | null> {