-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving LastWrittenLSNCache to Neon Extension #11031
base: main
Are you sure you want to change the base?
Conversation
If this PR added a GUC in the Postgres fork or
If you're an external contributor, a Neon employee will assist in |
7909 tests run: 7524 passed, 0 failed, 385 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6df3fc1 at 2025-03-12T19:09:05.383Z :recycle: |
d5be721
to
99adda4
Compare
# Conflicts: # pgxn/neon/neon.h
877b252
to
2d3d9d4
Compare
…/neon into thesuhas/add_lwlsn_neon_ext
5cc01ee
to
8f339e9
Compare
…ior for SetLastWrittenLSNForBlockv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PG17 tests timeout after many failures.
Personal experience would point to something that causes segfaults/panics/Assertion failures thus causing core dumps, which somehow makes the whole system slow to a halt.
Could there be a reason why this only happens in one of the PG17 test suites? Is there something different/unique about that test? |
It looks like it is the only test running debug+without_lfc, so that's probably a good indication? |
Problem
We currently have this code duplicated across different PG versions. Moving this to an extension would reduce duplication and simplify maintenance.
Summary of changes
Moving the LastWrittenLSN code from PG versions to the Neon extension and linking it with hooks.
Related Postgres PR: neondatabase/postgres#590
Closes: #10973