Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving LastWrittenLSNCache to Neon Extension #11031

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

thesuhas
Copy link
Contributor

@thesuhas thesuhas commented Feb 27, 2025

Problem

We currently have this code duplicated across different PG versions. Moving this to an extension would reduce duplication and simplify maintenance.

Summary of changes

Moving the LastWrittenLSN code from PG versions to the Neon extension and linking it with hooks.

Related Postgres PR: neondatabase/postgres#590

Closes: #10973

@thesuhas thesuhas requested review from a team as code owners February 27, 2025 22:14
Copy link

If this PR added a GUC in the Postgres fork or neon extension,
please regenerate the Postgres settings in the cloud repo:

make NEON_WORKDIR=path/to/neon/checkout \
  -C goapp/internal/shareddomain/postgres generate

If you're an external contributor, a Neon employee will assist in
making sure this step is done.

Copy link

github-actions bot commented Feb 27, 2025

7909 tests run: 7524 passed, 0 failed, 385 skipped (full report)


Code coverage* (full report)

  • functions: 32.5% (8730 of 26869 functions)
  • lines: 48.5% (74669 of 153983 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6df3fc1 at 2025-03-12T19:09:05.383Z :recycle:

@thesuhas thesuhas marked this pull request as ready for review February 28, 2025 22:08
@thesuhas thesuhas force-pushed the thesuhas/add_lwlsn_neon_ext branch from d5be721 to 99adda4 Compare February 28, 2025 22:14
@thesuhas thesuhas requested a review from a team as a code owner March 3, 2025 17:29
@thesuhas thesuhas force-pushed the thesuhas/add_lwlsn_neon_ext branch from 877b252 to 2d3d9d4 Compare March 3, 2025 18:12
@tristan957 tristan957 force-pushed the thesuhas/add_lwlsn_neon_ext branch from 5cc01ee to 8f339e9 Compare March 3, 2025 18:49
Copy link
Contributor

@MMeent MMeent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PG17 tests timeout after many failures.

Personal experience would point to something that causes segfaults/panics/Assertion failures thus causing core dumps, which somehow makes the whole system slow to a halt.

@thesuhas
Copy link
Contributor Author

The PG17 tests timeout after many failures.

Personal experience would point to something that causes segfaults/panics/Assertion failures thus causing core dumps, which somehow makes the whole system slow to a halt.

Could there be a reason why this only happens in one of the PG17 test suites? Is there something different/unique about that test?

@MMeent
Copy link
Contributor

MMeent commented Mar 12, 2025

Could there be a reason why this only happens in one of the PG17 test suites? Is there something different/unique about that test?

It looks like it is the only test running debug+without_lfc, so that's probably a good indication?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Move the last written LSN (LwLSN) cache into neon extension
4 participants