pageserver: remove L0 flush upload wait #11196
Open
+12
−143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, L0 flushes would wait for uploads, as a simple form of backpressure. However, this prevented flush pipelining and upload parallelism. It has since been disabled in production and replaced by L0 compaction backpressure.
Touches https://github.com/neondatabase/cloud/issues/24664.
Summary of changes
This patch removes L0 flush upload waits, but still accepts the
l0_flush_wait_upload
config option as a noop for backwards compatibility with current configurations. The config option will be removed once this has been deployed across the fleet.This won't be deployed until next week, at which point we should be reasonably sure we won't need to re-enable it.