Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: remove L0 flush upload wait #11196

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Mar 12, 2025

Problem

Previously, L0 flushes would wait for uploads, as a simple form of backpressure. However, this prevented flush pipelining and upload parallelism. It has since been disabled in production and replaced by L0 compaction backpressure.

Touches https://github.com/neondatabase/cloud/issues/24664.

Summary of changes

This patch removes L0 flush upload waits, but still accepts the l0_flush_wait_upload config option as a noop for backwards compatibility with current configurations. The config option will be removed once this has been deployed across the fleet.

This won't be deployed until next week, at which point we should be reasonably sure we won't need to re-enable it.

@erikgrinaker erikgrinaker requested a review from skyzh March 12, 2025 16:45
@erikgrinaker erikgrinaker requested a review from a team as a code owner March 12, 2025 16:45
Copy link

github-actions bot commented Mar 12, 2025

7909 tests run: 7523 passed, 1 failed, 385 skipped (full report)


Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_remote_storage_upload_queue_retries[release-pg14]"
Flaky tests (4)

Postgres 17

Postgres 16

Postgres 15

Test coverage report is not available

The comment gets automatically updated with the latest test results
d10cd01 at 2025-03-12T22:00:53.652Z :recycle:

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tests need to be fixed, otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants