-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for last written lsn cache #1949
Conversation
Look like this branch is based on the code in #1891 as The new test shares some similarities with the tests added in #1891. I think we can use tests in #1891 to test the Also, looks like CircleCI doesn't run because "We have detected an anomaly that violates the CircleCI Terms of Service. Troubleshoot", which is probably because the PR is submitted from Russia. |
95f8d5a
to
7702bcd
Compare
bf737c4
to
5351567
Compare
49060a9
to
1aeba2b
Compare
419c9ff
to
fb60c3b
Compare
e14b163
to
543f547
Compare
Can you separate the test changes and the code changes into two commits, and push them separately, please? That way, we'll get "before" and "after" measurements from the CI. |
Do you mean create separate PR for tests or just add tests in separate commit within this PR? |
You can use squash them into two commits on your laptop with "git rebase -i origin/master", and force push to the branch to update the PR. After the CI passes, you can do a regular push from your laptop with "git push origin last_written_lsn_cache:main". Hmm. Not sure the CI would run on 'main' separately for the two commits if you do that though. So two separate PRs is probably the easiest way to do it. |
4dea1a5
to
7c848c6
Compare
I have merged PR with tests and rebased this PR. |
Main:
last_written_lsn_cache: