Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vendor/postgres-v14 to include hotfix for unlogged tables with indexes #3688

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Feb 22, 2023

REL_14_STABLE_neon can't be merged as it apparently has bug in bitmap heap scan prefetch patch, and there is a user waiting for this fix, so let's hotfix.

neondatabase/postgres#259

@arssher arssher requested review from knizhnik and MMeent February 22, 2023 18:54
@arssher arssher requested a review from a team as a code owner February 22, 2023 18:54
@arssher arssher enabled auto-merge (rebase) February 22, 2023 18:55
@vadim2404
Copy link
Contributor

Is it relevant for pg14 only?

@MMeent
Copy link
Contributor

MMeent commented Feb 22, 2023

No, PG15 also has this issue

@arssher
Copy link
Contributor Author

arssher commented Feb 22, 2023

But the user is on v14, so hotfixing it is enough.

@MMeent
Copy link
Contributor

MMeent commented Feb 22, 2023

We have many more users on PG15. Why would we want to retain bugs in some postgres versions, but hotfix them in others?

@arssher
Copy link
Contributor Author

arssher commented Feb 22, 2023

Well, we haven't any complains, and next release is in 4 days; hotfixes needs additional actions and complicate the release flow. I don't mind much though, do you want to bump v15 here as well?

@MMeent
Copy link
Contributor

MMeent commented Feb 22, 2023

I don't mind much though, do you want to bump v15 here as well?

Please. Did you mean "do you want it to happen" or "do you want to do it"?

@arssher
Copy link
Contributor Author

arssher commented Feb 22, 2023

Whatever, I'll do :)

@arssher arssher force-pushed the unlogged-index-hotfix branch from 0f6eebd to 3d0b5ed Compare February 22, 2023 20:44
@arssher
Copy link
Contributor Author

arssher commented Feb 22, 2023

Pushed.

@arssher arssher merged commit 0692fff into main Feb 22, 2023
@arssher arssher deleted the unlogged-index-hotfix branch February 22, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants