Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember last written LSN when it is first requested #411

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Remember last written LSN when it is first requested #411

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57af58e
Remember last written LSN when it is first requested
Apr 8, 2024
ca3e0d5
Use rnode instead of rlocator
Apr 9, 2024
ef79f4d
Return updated LSN in SetLastWrittenLSN
Apr 10, 2024
98119eb
Remove wrong new line
Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/backend/access/transam/xlog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6133,6 +6133,11 @@ GetLastWrittenLSN(RelFileNode rnode, ForkNumber forknum, BlockNumber blkno)
entry = hash_search(lastWrittenLsnCache, &key, HASH_FIND, NULL);
if (entry != NULL)
lsn = entry->lsn;
else
{
LWLockRelease(LastWrittenLsnLock);
return SetLastWrittenLSNForBlock(lsn, rnode, forknum, blkno);
}
}
else
{
Expand Down Expand Up @@ -6160,17 +6165,19 @@ GetLastWrittenLSN(RelFileNode rnode, ForkNumber forknum, BlockNumber blkno)
* rnode.relNode can be InvalidOid, in this case maxLastWrittenLsn is updated.
* SetLastWrittenLsn with dummy rnode is used by createdb and dbase_redo functions.
*/
void
XLogRecPtr
SetLastWrittenLSNForBlockRange(XLogRecPtr lsn, RelFileNode rnode, ForkNumber forknum, BlockNumber from, BlockNumber n_blocks)
{
if (lsn == InvalidXLogRecPtr || n_blocks == 0 || lastWrittenLsnCacheSize == 0)
return;
return lsn;

LWLockAcquire(LastWrittenLsnLock, LW_EXCLUSIVE);
if (rnode.relNode == InvalidOid)
{
if (lsn > XLogCtl->maxLastWrittenLsn)
XLogCtl->maxLastWrittenLsn = lsn;
else
lsn = XLogCtl->maxLastWrittenLsn;
}
else
{
Expand All @@ -6189,6 +6196,8 @@ SetLastWrittenLSNForBlockRange(XLogRecPtr lsn, RelFileNode rnode, ForkNumber for
{
if (lsn > entry->lsn)
entry->lsn = lsn;
else
lsn = entry->lsn;
/* Unlink from LRU list */
dlist_delete(&entry->lru_node);
}
Expand All @@ -6211,34 +6220,36 @@ SetLastWrittenLSNForBlockRange(XLogRecPtr lsn, RelFileNode rnode, ForkNumber for
}
}
LWLockRelease(LastWrittenLsnLock);
return lsn;
}

/*
* SetLastWrittenLSNForBlock -- Set maximal LSN for block
*/
void
XLogRecPtr
SetLastWrittenLSNForBlock(XLogRecPtr lsn, RelFileNode rnode, ForkNumber forknum, BlockNumber blkno)
{
SetLastWrittenLSNForBlockRange(lsn, rnode, forknum, blkno, 1);
return SetLastWrittenLSNForBlockRange(lsn, rnode, forknum, blkno, 1);
}

/*
* SetLastWrittenLSNForRelation -- Set maximal LSN for relation metadata
*/
void

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too: Not a fan of the additional newline, but won't block it on this.

XLogRecPtr
SetLastWrittenLSNForRelation(XLogRecPtr lsn, RelFileNode rnode, ForkNumber forknum)
{
SetLastWrittenLSNForBlock(lsn, rnode, forknum, REL_METADATA_PSEUDO_BLOCKNO);
return SetLastWrittenLSNForBlock(lsn, rnode, forknum, REL_METADATA_PSEUDO_BLOCKNO);
}

/*
* SetLastWrittenLSNForDatabase -- Set maximal LSN for the whole database
*/
void
XLogRecPtr
SetLastWrittenLSNForDatabase(XLogRecPtr lsn)
{
RelFileNode dummyNode = {InvalidOid, InvalidOid, InvalidOid};
SetLastWrittenLSNForBlock(lsn, dummyNode, MAIN_FORKNUM, 0);
return SetLastWrittenLSNForBlock(lsn, dummyNode, MAIN_FORKNUM, 0);
}

void
Expand Down
8 changes: 4 additions & 4 deletions src/include/access/xlog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,10 @@ extern XLogRecPtr GetLastImportantRecPtr(void);

/* neon specifics */

extern void SetLastWrittenLSNForBlock(XLogRecPtr lsn, RelFileNode relfilenode, ForkNumber forknum, BlockNumber blkno);
extern void SetLastWrittenLSNForBlockRange(XLogRecPtr lsn, RelFileNode relfilenode, ForkNumber forknum, BlockNumber from, BlockNumber n_blocks);
extern void SetLastWrittenLSNForDatabase(XLogRecPtr lsn);
extern void SetLastWrittenLSNForRelation(XLogRecPtr lsn, RelFileNode relfilenode, ForkNumber forknum);
extern XLogRecPtr SetLastWrittenLSNForBlock(XLogRecPtr lsn, RelFileNode relfilenode, ForkNumber forknum, BlockNumber blkno);
extern XLogRecPtr SetLastWrittenLSNForBlockRange(XLogRecPtr lsn, RelFileNode relfilenode, ForkNumber forknum, BlockNumber from, BlockNumber n_blocks);
extern XLogRecPtr SetLastWrittenLSNForDatabase(XLogRecPtr lsn);
extern XLogRecPtr SetLastWrittenLSNForRelation(XLogRecPtr lsn, RelFileNode relfilenode, ForkNumber forknum);
extern XLogRecPtr GetLastWrittenLSN(RelFileNode relfilenode, ForkNumber forknum, BlockNumber blkno);

extern void SetRedoStartLsn(XLogRecPtr RedoStartLSN);
Expand Down