Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse up-down viewport navigation for Q and E keys #115

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

cvachha
Copy link
Contributor

@cvachha cvachha commented Oct 15, 2023

Reversing the up-down viewport camera translation navigation so that Q makes the camera go down and E makes the camera to go up (earlier they were swapped). This is to match the original Nerfstudio viewer (and also similar to Unity).

Regarding the up-down arrow keys for panning rotating up and down, I noticed that they are reversed compared to the original Nerfstudio viewer, however the current direction of movement for the up down arrow keys in Viser is more ideal for viewing meshes. I am wondering if there is a way to only customize the key input for the new Nerfstudio viewer without affecting Viser for only the up down arrow keys.

Reversing the up-down viewport camera translation navigation so that Q makes the camera go down and E makes the camera to go up (earlier they were swapped). This is to match the original Nerfstudio viewer (and also similar to Unity).

Regarding the up-down arrow keys for panning rotating up and down, I noticed that they are reversed compared to the earlier nerfstudio viewer, however the current direction of movement for the up down arrow keys in viser is more ideal for viewing meshes. I am wondering if there is a way to only customize the key input for the nerfstudio viewer without affecting viser for only the up down arrow keys.
@brentyi brentyi enabled auto-merge (squash) October 18, 2023 18:44
@brentyi brentyi merged commit 02c05c8 into main Oct 18, 2023
@brentyi brentyi deleted the cyrus/viewport_navigation_qe_keys branch October 18, 2023 18:48
@brentyi
Copy link
Collaborator

brentyi commented Oct 18, 2023

Regarding the up-down arrow keys for panning rotating up and down, I noticed that they are reversed compared to the original Nerfstudio viewer, however the current direction of movement for the up down arrow keys in Viser is more ideal for viewing meshes. I am wondering if there is a way to only customize the key input for the new Nerfstudio viewer without affecting Viser for only the up down arrow keys.

This is an interesting observation... do you have a sense if one of the options is more correct than the other? Is there some standard to follow here?

I believe the current setup in viser is just matched from the camera-controls library's example: https://yomotsu.github.io/camera-controls/examples/keyboard.html

As far as configuration goes, this wouldn't be hard to do if we think it would be generally useful to justify the extra code. (I'm not sure this is the case)

yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
…ject#115)

Reversing the up-down viewport camera translation navigation so that Q makes the camera go down and E makes the camera to go up (earlier they were swapped). This is to match the original Nerfstudio viewer (and also similar to Unity).

Regarding the up-down arrow keys for panning rotating up and down, I noticed that they are reversed compared to the earlier nerfstudio viewer, however the current direction of movement for the up down arrow keys in viser is more ideal for viewing meshes. I am wondering if there is a way to only customize the key input for the nerfstudio viewer without affecting viser for only the up down arrow keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants