Adding double side for mesh #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merge whenever you like. :) |
|
Ok!! I should improve (or at least document) this workflow, but to summarize I:
|
brentyi
approved these changes
May 8, 2023
yzslab
pushed a commit
to yzslab/viser
that referenced
this pull request
Oct 20, 2024
* trying to add mesh double side * Sync message defs + built client --------- Co-authored-by: Brent Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work at the moment, but if you could help me get it to work that would be great. :) Currently, it's only rendering one side of the mesh. The images below illustrate what I mean.