Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viewer dropdown types #23

Merged
merged 3 commits into from
May 25, 2023
Merged

Update viewer dropdown types #23

merged 3 commits into from
May 25, 2023

Conversation

tancik
Copy link
Collaborator

@tancik tancik commented May 24, 2023

No description provided.

@tancik tancik requested a review from brentyi May 24, 2023 22:17
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, although I want to revisit the third overload at some point

@brentyi brentyi merged commit a3f7172 into main May 25, 2023
@tancik tancik deleted the tancik/dropdown-types branch May 26, 2023 17:08
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
* Update types

* Fix type error

---------

Co-authored-by: Brent Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants