Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev and example packages to pyproject.toml #25

Merged
merged 3 commits into from
May 25, 2023
Merged

Add dev and example packages to pyproject.toml #25

merged 3 commits into from
May 25, 2023

Conversation

tancik
Copy link
Collaborator

@tancik tancik commented May 25, 2023

Make it easier for developers to get up and running using the same development pipeline.

  • Can someone who uses poetry test that these instructions work?
  • Should we have strict requirements or is >= fine?

@tancik tancik requested a review from brentyi May 25, 2023 20:09
@tancik tancik changed the title Add dev packages in pyproject.toml Add dev and example packages to pyproject.toml May 25, 2023
@brentyi
Copy link
Collaborator

brentyi commented May 25, 2023

I updated the poetry instructions; minor caveat here was that -E dev actually uninstalls the examples dependencies.
>= also seems fine at the current stage of the project.

@brentyi brentyi merged commit ab0127a into main May 25, 2023
@tancik tancik deleted the tancik/manage_dev_packages branch May 26, 2023 17:08
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@tancik @brentyi
Add dev and example packages to pyproject.toml (nerfstudio-project#25)
0a841ba 
* Manage dev packages

* Fix poetry lock, add examples

* Remove requirements.txt, update poetry install instructions

---------

Co-authored-by: Brent Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tancik @brentyi