Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "select" to "dropdown", improve types #33

Merged
merged 2 commits into from
May 26, 2023
Merged

Rename "select" to "dropdown", improve types #33

merged 2 commits into from
May 26, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented May 26, 2023

No description provided.

@brentyi brentyi requested a review from tancik May 26, 2023 21:48
@brentyi brentyi mentioned this pull request May 26, 2023
Closed
@brentyi brentyi enabled auto-merge (squash) May 26, 2023 21:50
tancik
tancik approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brentyi brentyi merged commit 896e00d into main May 26, 2023
@brentyi brentyi deleted the brent/dropdown_group_types branch May 26, 2023 21:56
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@brentyi
Rename "select" to "dropdown", improve types (nerfstudio-project#33)
f7c4af3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @tancik