Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton for configurable theme #40

Merged
merged 3 commits into from
May 31, 2023
Merged

Skeleton for configurable theme #40

merged 3 commits into from
May 31, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented May 28, 2023

Adds the ability to call:

server = viser.ViserServer()
server.configure_theme(
    canvas_background_color=(255, 0, 255),
)
while True:
    time.sleep(10.0)

To launch viser with a pink background. We can expand ThemeConfigurationMessage for other things like the title bar.

Relevant: #20, #21

@brentyi brentyi requested a review from jonahbedouch May 31, 2023 04:17
@brentyi brentyi enabled auto-merge (squash) May 31, 2023 04:18
jonahbedouch
jonahbedouch approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@jonahbedouch jonahbedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, good work!

@brentyi brentyi disabled auto-merge May 31, 2023 04:33
@brentyi brentyi merged commit b5e223b into main May 31, 2023
@brentyi brentyi deleted the brent/theme_configure branch May 31, 2023 04:33
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@brentyi
Skeleton for configurable theme (nerfstudio-project#40)
6552655 
* Start configurable theme

* Build, fix initial theme

* Reduce re-renders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahbedouch jonahbedouch jonahbedouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @jonahbedouch