Fix edge case when float slider initial value is an integer #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungmin99
reviewed
May 31, 2023
There was a problem hiding this comment.
It feels unintuitive that the return type == type(initial_value).
I'm wondering if it's better to enforce:
type(min) == type(max) == type(step) == type(initial_value)
, just so that the return type is consistent.
E.g., it's not clear what the behavior should be if we have:
min: 0
max: 10
step: 1
initial_value: 1.0
since in this case the slider's value type will be a float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.