Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi-panel support, bottom bar #44

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Jun 3, 2023

We put a lot of time into this, but not a lot of thought. I think it makes sense to remove for now.

@brentyi brentyi requested a review from chungmin99 June 3, 2023 06:49
@brentyi brentyi enabled auto-merge (squash) June 3, 2023 07:19
Copy link
Collaborator

@chungmin99 chungmin99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad, but understandable. logic checks out, simplifies code significantly. Should also make implementing clicks in viser easier.

@brentyi brentyi merged commit 9b639aa into main Jun 5, 2023
@brentyi brentyi deleted the brent/remove_bottom_bar branch June 5, 2023 21:55
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
* Remove multi-panel support, bottom bar

* Fix search params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants