Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement add_mesh_trimesh() #45

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Implement add_mesh_trimesh() #45

merged 5 commits into from
Jun 5, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Jun 5, 2023

No description provided.

@brentyi brentyi requested a review from chungmin99 June 5, 2023 09:43
@brentyi brentyi enabled auto-merge (squash) June 5, 2023 09:45
chungmin99
chungmin99 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@chungmin99 chungmin99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should be nice quality of life improvements and figuremaking. thank you.

@brentyi brentyi merged commit ac2e987 into main Jun 5, 2023
@brentyi brentyi deleted the brent/fancy_meshes branch June 5, 2023 22:12
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@brentyi
Implement add_mesh_trimesh() (nerfstudio-project#45)
1a6daf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chungmin99 chungmin99 chungmin99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @chungmin99