Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mercury RPC type update #556

Merged
merged 6 commits into from
Jun 6, 2022
Merged

feat: Mercury RPC type update #556

merged 6 commits into from
Jun 6, 2022

Conversation

fjchen7
Copy link
Contributor

@fjchen7 fjchen7 commented Jun 1, 2022

Update mercury RPC type following with nervosnetwork/mercury#423

@fjchen7 fjchen7 assigned quake and unassigned quake Jun 1, 2022
@fjchen7 fjchen7 requested a review from quake June 1, 2022 07:49
builder.addTo("ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqg6flmrtx8y8tuu6s3jf2ahv4l6sjw9hsc3t4tqv", BigInteger.valueOf(1));
builder.outputCapacityProvider(CapacityProvider.FROM);
Item item = ItemFactory.newIdentityItemByCkb(Address.decode(secp256SigHashAddress).getScript().args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Item item = ItemFactory.newIdentityItemByCkb(Address.decode(secp256SigHashAddress).getScript().args);
Item item = ItemFactory.newAddressItem(secp256SigHashAddress);

@fjchen7 fjchen7 requested a review from quake June 3, 2022 02:02
@fjchen7 fjchen7 merged commit 64f084c into nervosnetwork:transaction-abstraction Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants