Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resumeble verification #2799

Merged
merged 8 commits into from
Jul 9, 2021
Merged

resumeble verification #2799

merged 8 commits into from
Jul 9, 2021

Conversation

zhangsoledad
Copy link
Member

No description provided.

@zhangsoledad zhangsoledad requested a review from a team July 1, 2021 23:10
@zhangsoledad

This comment has been minimized.

Sign in to view
@zhangsoledad
Copy link
Member Author

sync-test

@zhangsoledad
Copy link
Member Author

benchmark

@doitian doitian added the u:ckb2021 Upgrade: Fork ckb2021 label Jul 2, 2021
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 96d1626 to c0d16cc Compare July 2, 2021 01:56
@nervos-bot-user
Copy link
Collaborator

Sync Test Result

  • CKB Version: 96d1626
  • Instance Region: ap-southeast-1
  • Sync Start: 2021-07-01 23:30:04
  • Sync End: 2021-07-02 01:51:29
  • Sync Height: 4692991
  • Sync Speed: 553 blocks/s

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from c0d16cc to 9d1b2a5 Compare July 2, 2021 02:30
@zhangsoledad zhangsoledad changed the title resumeble verification [hold] resumeble verification Jul 2, 2021
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 9d1b2a5 to 8051a20 Compare July 5, 2021 17:54
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 8051a20 to e76a1ba Compare July 5, 2021 19:02
doitian
doitian reviewed Jul 6, 2021
View reviewed changes
doitian
doitian reviewed Jul 6, 2021
View reviewed changes
doitian
doitian reviewed Jul 6, 2021
View reviewed changes
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from e76a1ba to 6ed031c Compare July 6, 2021 06:15
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 6ed031c to 8863dbc Compare July 6, 2021 07:42
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 8863dbc to 4339ab0 Compare July 6, 2021 09:00
chaoticlonghair
chaoticlonghair suggested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@chaoticlonghair chaoticlonghair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CKB-VM v0.20.0-rc1 is released.

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 4339ab0 to 87c7b53 Compare July 6, 2021 11:00
chaoticlonghair
chaoticlonghair previously approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@chaoticlonghair chaoticlonghair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR remove the "Hold" tag in title?

@zhangsoledad zhangsoledad changed the title [hold] resumeble verification resumeble verification Jul 6, 2021
@chaoticlonghair chaoticlonghair added s:waiting-on-reviewers Status: Waiting for Review p:must-have Priority: critical to the current delivery timebox in order for it to be a success s:blocking Status: This PR must be merged first labels Jul 6, 2021
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from 0ad5ee1 to b74f834 Compare July 6, 2021 20:52
@zhangsoledad
Copy link
Member Author

sync-test, benchmark

@nervos-bot-user
Copy link
Collaborator

Sync Test Result

  • CKB Version: c66df44
  • Instance Region: ap-southeast-1
  • Sync Start: 2021-07-06 21:50:17
  • Sync End: 2021-07-07 00:11:04
  • Sync Height: 4734729
  • Sync Speed: 560 blocks/s

driftluo
driftluo previously approved these changes Jul 7, 2021
View reviewed changes
chaoticlonghair
chaoticlonghair previously approved these changes Jul 7, 2021
View reviewed changes
@zhangsoledad zhangsoledad dismissed stale reviews from chaoticlonghair and driftluo via da99c0f July 7, 2021 08:12
driftluo
driftluo previously approved these changes Jul 7, 2021
View reviewed changes
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/resume branch from da99c0f to f778cb0 Compare July 7, 2021 10:09
@driftluo
Copy link
Collaborator

driftluo commented Jul 9, 2021

bors r=driftluo,quake

@bors
Copy link
Contributor

bors bot commented Jul 9, 2021

Build succeeded:

@bors bors bot merged commit a8deefe into nervosnetwork:develop Jul 9, 2021
@chaoticlonghair chaoticlonghair removed p:must-have Priority: critical to the current delivery timebox in order for it to be a success s:blocking Status: This PR must be merged first s:waiting-on-reviewers Status: Waiting for Review labels Jul 9, 2021
@driftluo driftluo mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian left review comments

@quake quake quake approved these changes

@driftluo driftluo driftluo approved these changes

@chaoticlonghair chaoticlonghair chaoticlonghair left review comments

@keroro520 keroro520 Awaiting requested review from keroro520

@xxuejie xxuejie Awaiting requested review from xxuejie

Assignees
No one assigned
Labels
u:ckb2021 Upgrade: Fork ckb2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangsoledad @nervos-bot-user @driftluo @quake @doitian @chaoticlonghair