Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix tcp reuse bind #3566

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fix: fix tcp reuse bind #3566

merged 1 commit into from
Sep 7, 2022

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Sep 6, 2022 •
edited
Loading

What problem does this PR solve?

fix #2654 (reply in thread)

Fix the panic caused by the configuration file

Reuse-bind cannot be performed between ipv4 and ipv6, and branch judgment is required

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner September 6, 2022 02:41
@driftluo driftluo requested review from quake and removed request for a team September 6, 2022 02:41
@quake
Copy link
Member

quake commented Sep 7, 2022

bors r=quake

@bors
Copy link
Contributor

bors bot commented Sep 7, 2022

Build succeeded:

@bors bors bot merged commit 2fc40a0 into nervosnetwork:develop Sep 7, 2022
@driftluo driftluo deleted the fix-tcp-reuse-bind branch September 7, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driftluo @quake