Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(script): make DataLocation public #4815

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

mohanson
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

The ckb-debugger needs to use this data structure.

What is changed and how it works?

What's Changed:

Make it public.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

Release note

None: Exclude this PR from the release note.

@mohanson mohanson requested a review from a team as a code owner February 24, 2025 09:33
@mohanson mohanson requested review from doitian and removed request for a team February 24, 2025 09:33
eval-exec
eval-exec previously approved these changes Feb 24, 2025
zhangsoledad
zhangsoledad previously approved these changes Feb 24, 2025
@zhangsoledad
Copy link
Member

All public types must have corresponding documentation. @mohanson

@zhangsoledad zhangsoledad self-requested a review February 24, 2025 12:24
@mohanson mohanson dismissed stale reviews from zhangsoledad and eval-exec via 39ab476 February 24, 2025 12:27
@mohanson
Copy link
Contributor Author

All public types must have corresponding documentation. @mohanson

Fixed.

@zhangsoledad
Copy link
Member

zhangsoledad commented Feb 24, 2025

All public types must have corresponding documentation. @mohanson

Fixed.

Missing documentation for struct fields @mohanson

@zhangsoledad zhangsoledad added this pull request to the merge queue Feb 26, 2025
Merged via the queue into nervosnetwork:develop with commit c53044e Feb 26, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants