Save our own broadcast message directly and save raw gossip message from peers to memory first #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
force-pushed
the
cache-chain-actor-results
branch
from
a12f301 to
048d740
Compare
quake
reviewed
Jan 2, 2025
contrun
force-pushed
the
cache-chain-actor-results
branch
3 times, most recently
from
d58843a to
7f72010
Compare
contrun
force-pushed
the
cache-chain-actor-results
branch
from
7f72010 to
3b371bc
Compare
contrun
changed the title
contrun
force-pushed
the
cache-chain-actor-results
branch
from
c859164 to
5649b07
Compare
contrun
force-pushed
the
cache-chain-actor-results
branch
from
cf6cca4 to
a82e613
Compare
contrun
changed the title
contrun
force-pushed
the
cache-chain-actor-results
branch
from
93bdbb5 to
17d4a19
Compare
contrun
force-pushed
the
cache-chain-actor-results
branch
from
d63f40c to
c046a60
Compare
quake
reviewed
Jan 6, 2025
quake
reviewed
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While verifying gossip messages, the first thing we need to do is to obtain the
ChannelAnnouncementtimestamp. This operation requires interaction with the CKB chain. As an implementation detail, we need to obtain the whole transaction for the timestamp in the block header. So it is possible that we will call the chain actor a few times in order to process the gossip message. This PR attempts to cache theChannelAnnouncementtimestamp and the channel transaction in memory to reduce the interaction with the CKB chain. It also fixes the two problems in the comment of #414