-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle private channel hop hints #487
Merged
quake
merged 41 commits into
nervosnetwork:develop
from
contrun:handle-private-channel-hop-hints
Mar 6, 2025
Merged
Handle private channel hop hints #487
quake
merged 41 commits into
nervosnetwork:develop
from
contrun:handle-private-channel-hop-hints
Mar 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into handle-private-channel-hop-hints
8f14f6b
to
3dd662a
Compare
chenyukang
reviewed
Jan 24, 2025
chenyukang
reviewed
Jan 24, 2025
chenyukang
reviewed
Jan 24, 2025
…ate-channel-hop-hints
454289d
to
5ae0dfe
Compare
5ae0dfe
to
2b5c9a2
Compare
00853af
to
55b2764
Compare
…ate-channel-hop-hints
9529349
to
08c64cd
Compare
…andle-private-channel-hop-hints
chenyukang
reviewed
Mar 6, 2025
quake
reviewed
Mar 6, 2025
quake
approved these changes
Mar 6, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on Use the fee rate in oubound channel to calculate the TLC fee by contrun · Pull Request #489 · nervosnetwork/fiber.
The migration code is not well-tested. I only tried the following.
git checkout v0.3.1
to checkout to the v0.3.1 version code.REMOVE_OLD_STATE=y ./tests/nodes/start.sh
to start a few fnn nodes with all new states.(cd ./tests/bruno; npm exec -- @usebruno/[email protected] run e2e/router-pay -r --env test)
to create a few payment sessions.ldb --db=tests/nodes/1/fiber/store --secondary_path=/tmp/test/ dump --hex | awk '/0xC0/ {print $1}' | sed 's/0xC0/0x/g'
to see all the payment sessions created.ldb --db=tests/nodes/1/fiber/store --secondary_path=/tmp/test/ dump --hex | awk '/0xC0/ {print $1}' | sed 's/0xC0/0x/g' | xargs -I __ curl -sS --json '{"id": "42", "jsonrpc": "2.0", "method": "get_payment", "params": [{"payment_hash": "__"}]}' http://127.0.0.1:21714/ | jq -s
to see all the payment session detailed information.git checkout handle-private-channel-hop-hints
to checkout the code of this PR.(cd migrate; cargo run -- --path ../tests/nodes/1/fiber/store)
to start migration.cargo build && (clear; cd ./tests/nodes/; ../../target/debug/fnn -d 1)
to start node 1.ldb --db=tests/nodes/1/fiber/store --secondary_path=/tmp/test/ dump --hex | awk '/0xC0/ {print $1}' | sed 's/0xC0/0x/g' | xargs -I __ curl -sS --json '{"id": "42", "jsonrpc": "2.0", "method": "get_payment", "params": [{"payment_hash": "__"}]}'
again to check the payment session data have been migrated (by eyes).