This repository was archived by the owner on Apr 9, 2024. It is now read-only.
refactor(arch): split rpc module to core types and utility #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
force-pushed
the
refactor-architecture
branch
from
8a2f248 to
46ec0e7
Compare
KaoImin
force-pushed
the
refactor-architecture
branch
2 times, most recently
from
0373793 to
ce8e88c
Compare
rev-chaos
reviewed
Nov 18, 2021
rev-chaos
reviewed
Nov 22, 2021
README.md
Outdated
| - [Mercury Config Documentation](docs/config.md) | ||
| - [Mercury Layout Documentation](docs/layout.md) |
There was a problem hiding this comment.
Should we append contribution doc here?
There was a problem hiding this comment.
In my opinion, the documents listed here are related to mercury, and a should be placed in a separate section, reference the usage in ckb .
added 20 commits
November 22, 2021 10:33
rev-chaos
reviewed
Nov 22, 2021
| @@ -0,0 +1,23 @@ | |||
| [package] | |||
| name = "extension-templete" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Suggested change
| version = "0.1.0" | |
| version = "0.2.0-beta.4" |
rev-chaos
approved these changes
Nov 22, 2021
EthanYuan
approved these changes
Nov 22, 2021
KaoImin
force-pushed
the
refactor-architecture
branch
from
a0421a4 to
898345c
Compare
KaoImin
pushed a commit
that referenced
this pull request
Dec 1, 2021
* refactor: build rpc types crate * refactor: peel ckb client * refactor: error handle * remove old rpc * refactor * refactor: remove extension module * add extension templete * remove db protocol * change extension templete * recover rpc tests * change templete name * fix CI * add docs * rebase dev * cargo update * update doc * change crates version * update readme * add how to contribute * rebase dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactor the mercury architecture.
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer: