Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

feat(rpc): improve transfer transaction building #322

Merged
merged 11 commits into from
Dec 1, 2021

Conversation

EthanYuan
Copy link
Collaborator

What this PR does / why we need it:

  • support acp cell to pool ckb
  • support dao cell(unlock) to pool ckb
  • support dynamic change, which means that not all situations require a new output secp cell for change
  • convert secp udt cell with zero udt to secp ckb cell
  • simplifies the building of transfer transactions
  • makes the pool logic more cohesive

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

@EthanYuan EthanYuan changed the title Refactoring transfer tx feat(rpc): improve transfer transaction building Nov 25, 2021
@EthanYuan EthanYuan force-pushed the refactoring-transfer-tx branch from 3d8776c to 221d8c6 Compare November 29, 2021 09:03
@EthanYuan EthanYuan force-pushed the refactoring-transfer-tx branch from 69dcc85 to 01527bc Compare November 29, 2021 15:07
@EthanYuan EthanYuan force-pushed the refactoring-transfer-tx branch from 8ab8563 to a34dd47 Compare December 1, 2021 03:26
@rev-chaos rev-chaos merged commit d39db37 into dev Dec 1, 2021
KaoImin pushed a commit that referenced this pull request Dec 1, 2021
* add types for building transfer tx.

* add error for building transfer tx.

* add utils method for building transfer tx.

* add new build transfer tx method.

* new utils_types mod.

* fix: caculate output cell extra capacity in building tx.

* modify pool ckb logic: acp live cell priority is last

* fix: from items must not contain the to item.

* fix: dao reward related.

* rebase.

* fix udt change in Source::Claimable.
@EthanYuan EthanYuan deleted the refactoring-transfer-tx branch December 1, 2021 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants