Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

refactor(rpc): update rpc type and enum #422

Merged
merged 2 commits into from
May 27, 2022

Conversation

EthanYuan
Copy link
Collaborator

What this PR does / why we need it:

  • modify enum ScriptGroupType(LockScript/TypeScript -> Lock/Type)
  • enum input parameters support snake name aliases
  • break changes:
    • ExtraType::CellBase -> ExtraType::Cellbase (correct spelling)
    • ExtraFilter::CellBase -> ExtraFilter::Cellbase (correct spelling)
    • ExtraFilter::Freeze -> ExtraFilter::Frozen (uniform naming)
    • TransactionStatus::committed -> TransactionStatus::Committed(unified style:Capitalize the first letter of the output enume value)

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

Breaking Change

Special notes for your reviewer:

EthanYuan added 2 commits May 27, 2022 19:21
* modify group_type enum value
* ExtraType::CellBase -> ExtraType::Cellbase
* ExtraFilter::CellBase -> ExtraFilter::Cellbase
* ExtraFilter::Freeze -> ExtraFilter::Frozen
* TransactionStatus::committed -> TransactionStatus::Committed
@EthanYuan EthanYuan merged commit 36c17f1 into nervosnetwork:dev-0.4 May 27, 2022
@EthanYuan EthanYuan deleted the dev-0.4-enum branch May 27, 2022 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants