This repository was archived by the owner on Apr 9, 2024. It is now read-only.
fix(rpc): transactions generated by rpc build_dao_claim_transaction will cause random -14 dao script validation error
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanYuan
changed the title
test_dao_by_out_pointbuild_dao_claim_transaction will cause random -14 dao script validation error
quake
approved these changes
Jun 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed a randomly failing integration test:
test_dao_by_out_pointtest_dao_by_out_point, in this test case, the withdrawing cells are from different transactions.get_transactions_with_statusreturns theinput_cellsin the transaction but the order is not guaranteed to be in the order in the transaction. In this case,build_dao_claim_transactionrelies on the assumption that theinput_cellsare in order to locate the deposit cells by withdrawing cells’ outpoint index.refactored integration test
test_simple_transfer_udt_from_provide_capacity：avoid the possibility of affecting other tests.Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer: