This repository was archived by the owner on Apr 9, 2024. It is now read-only.
refactor(rpc): change the get balance interface #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rev-chaos
reviewed
Jul 16, 2021
rev-chaos
reviewed
Jul 16, 2021
rev-chaos
reviewed
Jul 16, 2021
Co-authored-by: rev-chaos <[email protected]>
rev-chaos
reviewed
Jul 16, 2021
| udt_hashes: Vec<Option<H256>>, | ||
| udt_hashes: HashSet<Option<H256>>, | ||
| address: QueryAddress, | ||
| block_number: Option<u64>, |
There was a problem hiding this comment.
// Not support yet, so we should return error, when the block_number is none, which is missed now
added 2 commits
July 16, 2021 16:31
rev-chaos
approved these changes
Jul 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
get_balanceinterface to a struct.udt_hashesto aHashSet, if it is empty, means to get the balance of all assets.Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer: