This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat(rpc): add get generic transaction and generic block interface #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rev-chaos
reviewed
Jul 20, 2021
rev-chaos
reviewed
Jul 20, 2021
rev-chaos
reviewed
Jul 20, 2021
| let udt_amount = InnerAmount { | ||
| value: self.get_udt_amount(is_input, cell_data.raw_data()), | ||
| udt_hash: cell.type_().to_opt().map(|s| s.calc_script_hash().unpack()), | ||
| status: Status::Unconstrained, |
There was a problem hiding this comment.
for cheque, status should be fleeting
There was a problem hiding this comment.
for other script, udt status should be locked
There was a problem hiding this comment.
Why the udt status is locked except cheque?
There was a problem hiding this comment.
because when collecting udt inputs, mercury will not use other script, so these udt behave like locked
rev-chaos
reviewed
Jul 20, 2021
rev-chaos
reviewed
Jul 20, 2021
added 2 commits
July 20, 2021 23:20
rev-chaos
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer: