This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat(rpc): build asset collection transaction #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitrocks
force-pushed
the
build-asset-collection-transaction
branch
from
1dae6a3 to
68fd8c4
Compare
bitrocks
changed the title
rev-chaos
reviewed
Jul 23, 2021
core/rpc/src/rpc_impl/transfer.rs
Outdated
| let key_addr = Address::new( | ||
| self.net_ty, | ||
| self.get_script_by_hash(to_fixed_array( | ||
| &script.args().raw_data()[20..40], |
There was a problem hiding this comment.
Suggested change
| &script.args().raw_data()[20..40], | |
| &script.args().raw_data()[0..20], |
rev-chaos
reviewed
Jul 23, 2021
| ) -> Result<TransactionCompletionResponse> { | ||
| let from_addresses = self.parse_from_addresses(from, udt_hash.is_some())?; | ||
| let to_address = self.parse_to_address(to, udt_hash.is_some())?; | ||
| let fee_address = parse_address(&fee_paid_by)?; |
There was a problem hiding this comment.
Suggested change
| let fee_address = parse_address(&fee_paid_by)?; | |
| let fee_address = parse_key_address(&fee_paid_by)?; |
rev-chaos
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer: