Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadTheDocs font is underspecified #2322

Closed
clinssen opened this issue Mar 2, 2022 · 3 comments
Closed

ReadTheDocs font is underspecified #2322

clinssen opened this issue Mar 2, 2022 · 3 comments
Assignees
@jessica-mitchell
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@clinssen
Copy link
Contributor

clinssen commented Mar 2, 2022

Opening https://nest-simulator.readthedocs.org/ in Chrome 91 on Debian Linux renders with a fixed-width font.

It seems that the computed font for the main text is

system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", "Liberation Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"

I fear that "system-ui" is not specific enough to achieve a consistent rendering across platforms.
@clinssen clinssen added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Mar 7, 2022
@jessica-mitchell
Copy link
Contributor

@clinssen there is indeed some odd behaviour with the font. I explicitly added a font-family to the custom css. Could you check on your system how this looks: https://nest-test.readthedocs.io/en/fix-font-rtd/index.html
thanks!

Also, fyi, the font-family in for the forthcoming new theme (#2289), is included in the css as well.

@jessica-mitchell jessica-mitchell self-assigned this Mar 29, 2022
@github-actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 29, 2022
@jessica-mitchell
Copy link
Contributor

Marking this as closed since #2289 should have resolved font issues. Please create a new issue if issue comes up again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessica-mitchell jessica-mitchell

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessica-mitchell @clinssen