-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new Read the docs theme with custom index #2289
Conversation
@jougs after our discussion here are the changes I managed (also @heplesser @steffengraber fyi)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, a big step for the documentation.
To improve the mobile view, I have just one small note in custom.css
.
A general question: is it necessary to have the full bootstrap stack (js and css) in the code? Or is it not possible to leave some of it out?
One more note: There are also many content adjustments that don't necessarily have anything to do with theme customization. Wouldn't it have been better to put this in another pull request?
… attribute strings
@steffengraber
I just followed steps from the bootstrap site, and it might be excessive to have it all, perhaps in follow up PR I can look at simplifying this
Yah probably, but now it would be very time consuming to review commits, it largely stemmed from trying to get the output to look decent and I probably got carried away with other fixes along the way. |
@heplesser I fixed up the API, including the spacing between elements in the kernel attributes which was mentioned at the NEST conference https://nest-test.readthedocs.io/en/rtd-theme/ref_material/pynest_apis.html |
@jessica-mitchell can we have a link for NESTML on the main menu? Instead of |
@pnbabu |
Co-authored-by: Jochen Martin Eppler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had another walk though and here's some things I noticed. I also noticed that some of the things we discussed earlier are fixed now and I like those much better now :-)
- I agree with @pnbabu and think that "Built-in models" and "Custom models" represent reality much better than just "Models" and "Customize models"
- When I'm at the index of the developer space, the "Related Projects" button at the top takes me to the maze, as does "Contact us"
I see that the |
… for index.html, fix up colors, grids, positions in css
…ial, change to whats_new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this extensive contribution! It looks very good to me. 👍
This PR introduces a new theme (based on Sphinx Material) for the Read the docs documentation.
It also include a new template for index.html. Thanks to @jougs for developing a more interactive and attractive theme!
The goal is to provide users with different ways to explore the docs, improve the context for the different guides and resources, and enhance the overall theme.
Set as draft as discussion and bit more tweaking is needed. Also #2283 needs to be merged first.